Page MenuHomePhabricator

Don't generate junit report for functional test unless being asked to
ClosedPublic

Authored by Fabien on Tue, Jul 28, 07:18.

Details

Summary

The current behavior is to generate the report by defauly, but the
feature is only used by CI. This diff changes this behavior to only
create the report file if the --junitoutput option is set.
This fixes an old issue where the test/tmp directory was not correctly
emptied after running the functional tests due to the junit file not
being removed.

Depends on D7004.

Test Plan
ninja check-functional

Check the test/tmp dir is empty and not junit file is generated.

cmake -GNinja .. -DENABLE_JUNIT_REPORT=ON
ninja check-functional

Check the test/junit directory contains the report and the test/tmp
directory is empty.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jul 28, 07:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jul 28, 07:18
Fabien requested review of this revision.Tue, Jul 28, 07:18
deadalnix accepted this revision.Tue, Jul 28, 12:09
This revision is now accepted and ready to land.Tue, Jul 28, 12:09