Don't generate junit report for functional test unless being asked to
ClosedPublic
Actions

Authored by Fabien on Jul 28 2020, 07:18.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCf03faa468ce0: Don't generate junit report for functional test unless being asked to

Summary

The current behavior is to generate the report by defauly, but the
feature is only used by CI. This diff changes this behavior to only
create the report file if the --junitoutput option is set.
This fixes an old issue where the test/tmp directory was not correctly
emptied after running the functional tests due to the junit file not
being removed.

Depends on D7004.

Test Plan

ninja check-functional

Check the test/tmp dir is empty and not junit file is generated.

cmake -GNinja .. -DENABLE_JUNIT_REPORT=ON
ninja check-functional

Check the test/junit directory contains the report and the test/tmp
directory is empty.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 28 2020, 07:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2020, 07:18

Fabien requested review of this revision.Jul 28 2020, 07:18

Harbormaster completed remote builds in B12193: Diff 22562.Jul 28 2020, 07:43

deadalnix accepted this revision.Jul 28 2020, 12:09

This revision is now accepted and ready to land.Jul 28 2020, 12:09

Closed by commit rABCf03faa468ce0: Don't generate junit report for functional test unless being asked to (authored by Fabien). · Explain WhyJul 29 2020, 10:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf03faa468ce0: Don't generate junit report for functional test unless being asked to.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_runner.py

12 lines

Diff 22600

View Options

test/functional/test_runner.py

Don't generate junit report for functional test unless being asked toClosedPublicActions