Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC40b60bbb3c03: [CMAKE] Move the functional tests junit reports to the test/junit dir

Summary

The goal is to have a single output directory for all the junit reports.
The report directory is now always created when any test target is run.

Depends on D7002.

Test Plan

ninja check-functional

Check the report is generated to the test/junit directory.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 22 2020, 15:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2020, 15:22

Fabien requested review of this revision.Jul 22 2020, 15:22

Harbormaster completed remote builds in B12105: Diff 22425.Jul 22 2020, 15:37

deadalnix requested changes to this revision.Jul 22 2020, 23:13

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

cmake/modules/TestSuite.cmake
14 ↗	(On Diff #22425)	No need for a folder.
test/CMakeLists.txt
59 ↗	(On Diff #22425)	`test/junit` ? Not a big fan of dumping everythign at the root. Also, make sure this is geting clearer on `ninja clean`

This revision now requires changes to proceed.Jul 22 2020, 23:13

Fabien mentioned this in D7002: [CMAKE] Generate junit output for boost unit tests.Jul 23 2020, 07:06

Fabien planned changes to this revision.Jul 23 2020, 07:07

Fabien added inline comments.

cmake/modules/TestSuite.cmake
14 ↗	(On Diff #22425)	The whole point of this diff is to move toward a single directory for all the junit files so the CI knows where to look and new files as needed with no further configuration.

Fabien edited the test plan for this revision. (Show Details)Jul 23 2020, 07:41

Fabien retitled this revision from [CMAKE] Move the functional tests junit reports to the junit_reports dir to [CMAKE] Move the functional tests junit reports to the test/junit dir.Jul 23 2020, 07:47

Rebase on top of updated D7002 to address feedbacks: