Page MenuHomePhabricator
Differential D7004

[CMAKE] Move the functional tests junit reports to the test/junit dir
ClosedPublic
Actions

Authored by Fabien on Jul 22 2020, 15:22.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC40b60bbb3c03: [CMAKE] Move the functional tests junit reports to the test/junit dir
Summary

The goal is to have a single output directory for all the junit reports.
The report directory is now always created when any test target is run.

Depends on D7002.

Test Plan
ninja check-functional

Check the report is generated to the test/junit directory.

Diff Detail

Event Timeline

Fabien created this revision.Jul 22 2020, 15:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 22 2020, 15:22
Fabien requested review of this revision.Jul 22 2020, 15:22
Harbormaster completed remote builds in B12105: Diff 22425.Jul 22 2020, 15:37
deadalnix requested changes to this revision.Jul 22 2020, 23:13
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/modules/TestSuite.cmake
14

No need for a folder.

test/CMakeLists.txt
59

test/junit ?

Not a big fan of dumping everythign at the root.

Also, make sure this is geting clearer on ninja clean

This revision now requires changes to proceed.Jul 22 2020, 23:13
Fabien mentioned this in D7002: [CMAKE] Generate junit output for boost unit tests.Jul 23 2020, 07:06
Fabien planned changes to this revision.Jul 23 2020, 07:07
Fabien added inline comments.
cmake/modules/TestSuite.cmake
14

The whole point of this diff is to move toward a single directory for all the junit files so the CI knows where to look and new files as needed with no further configuration.

Fabien edited the test plan for this revision. (Show Details)Jul 23 2020, 07:41
Fabien retitled this revision from [CMAKE] Move the functional tests junit reports to the junit_reports dir to [CMAKE] Move the functional tests junit reports to the test/junit dir.Jul 23 2020, 07:47
Fabien updated this revision to Diff 22454.Jul 23 2020, 07:48

Rebase on top of updated D7002 to address feedbacks:

  • The report directory moved to test/junit
  • The report directory is cleaned by the clean target
Harbormaster completed remote builds in B12130: Diff 22454.Jul 23 2020, 07:59
deadalnix accepted this revision.Jul 23 2020, 12:07
This revision is now accepted and ready to land.Jul 23 2020, 12:07
Fabien updated this revision to Diff 22501.Jul 24 2020, 19:40

Rebase and remove junit_ prefix to match the naming convention from D7002.

Harbormaster completed remote builds in B12151: Diff 22501.Jul 24 2020, 19:54
Fabien planned changes to this revision.Jul 27 2020, 19:58

Is going to need rebase

Fabien updated this revision to Diff 22558.Jul 28 2020, 06:59

Rebase, take ENABLE_JUNIT_REPORT into account

This revision is now accepted and ready to land.Jul 28 2020, 06:59
Harbormaster completed remote builds in B12191: Diff 22558.Jul 28 2020, 07:14
Fabien added a child revision: D7058: Don't generate junit report for functional test unless being asked to.Jul 28 2020, 07:18
Closed by commit rABC40b60bbb3c03: [CMAKE] Move the functional tests junit reports to the test/junit dir (authored by Fabien). · Explain WhyJul 28 2020, 10:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC40b60bbb3c03: [CMAKE] Move the functional tests junit reports to the test/junit dir.

Revision Contents
Changeset List

PathSize
cmake/
modules/
1 line
test/
21 lines

Diff 22425

View Options

cmake/modules/TestSuite.cmake

Loading...
View Options

test/CMakeLists.txt

Loading...