Page MenuHomePhabricator

[CMAKE] Move the functional tests junit reports to the test/junit dir
ClosedPublic

Authored by Fabien on Jul 22 2020, 15:22.

Details

Summary

The goal is to have a single output directory for all the junit reports.
The report directory is now always created when any test target is run.

Depends on D7002.

Test Plan
ninja check-functional

Check the report is generated to the test/junit directory.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Jul 22 2020, 15:22
deadalnix requested changes to this revision.Jul 22 2020, 23:13
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
cmake/modules/TestSuite.cmake
14 ↗(On Diff #22425)

No need for a folder.

test/CMakeLists.txt
59 ↗(On Diff #22425)

test/junit ?

Not a big fan of dumping everythign at the root.

Also, make sure this is geting clearer on ninja clean

This revision now requires changes to proceed.Jul 22 2020, 23:13
Fabien planned changes to this revision.Jul 23 2020, 07:07
Fabien added inline comments.
cmake/modules/TestSuite.cmake
14 ↗(On Diff #22425)

The whole point of this diff is to move toward a single directory for all the junit files so the CI knows where to look and new files as needed with no further configuration.

Fabien retitled this revision from [CMAKE] Move the functional tests junit reports to the junit_reports dir to [CMAKE] Move the functional tests junit reports to the test/junit dir.Jul 23 2020, 07:47

Rebase on top of updated D7002 to address feedbacks:

  • The report directory moved to test/junit
  • The report directory is cleaned by the clean target
This revision is now accepted and ready to land.Jul 23 2020, 12:07

Rebase and remove junit_ prefix to match the naming convention from D7002.

Fabien planned changes to this revision.Jul 27 2020, 19:58

Is going to need rebase

Rebase, take ENABLE_JUNIT_REPORT into account

This revision is now accepted and ready to land.Jul 28 2020, 06:59