Page MenuHomePhabricator
Differential D7132

[backport#18206] tests: Add fuzzing harness for bloom filter classes (CBloomFilter + CRollingBloomFilter)
ClosedPublic
Actions

Authored by majcosta on Aug 5 2020, 09:59.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC3015e8733ec7: [backport#18206] tests: Add fuzzing harness for bloom filter classes…
Summary

Add fuzzing harness for rolling bloom filter class CRollingBloomFilter (practicalswift)
Add fuzzing harness for bloom filter class CBloomFilter (practicalswift)

Add fuzzing harness for bloom filter classes (`CBloomFilter` + `CRollingBloomFilter`).

https://github.com/bitcoin/bitcoin/pull/18206/files

Backport of Core PR18206

Test Plan
cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
ninja bitcoin-fuzzers
./src/test/fuzz/bloom_filter
./src/test/fuzz/rolling_bloom_filter

../configure --enable-fuzz --with-sanitizers=fuzzer,address --disable-wallet --disable-bench --with-utils=no --with-daemon=no --with-libs=no --with-gui=no --with-seeder=no --enable-deprecated-build-system --without-miniupnpc --disable-zmq
make
./test/fuzz/test_runner.py -l DEBUG [path_to_corpus]

Diff Detail

Event Timeline

majcosta created this revision.Aug 5 2020, 09:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2020, 09:59
majcosta requested review of this revision.Aug 5 2020, 09:59
Harbormaster completed remote builds in B12311: Diff 22754.Aug 5 2020, 10:14
majcosta edited the test plan for this revision. (Show Details)Aug 5 2020, 10:52
majcosta added a child revision: D7133: [backport#18417 1/3] tests: Add fuzzing harness for functions in addrdb.h.Aug 5 2020, 10:54
majcosta edited the summary of this revision. (Show Details)
jasonbcox requested changes to this revision.Aug 5 2020, 22:22
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/Makefile.test.include
100 ↗(On Diff #22754)

This change is broken and autotools needs to be added to the test plan.

This revision now requires changes to proceed.Aug 5 2020, 22:22
majcosta updated this revision to Diff 22776.Aug 6 2020, 18:50

fix and rebase

majcosta edited the test plan for this revision. (Show Details)Aug 6 2020, 18:54
Harbormaster completed remote builds in B12324: Diff 22776.Aug 6 2020, 19:13
jasonbcox requested changes to this revision.Aug 6 2020, 21:24
jasonbcox added inline comments.
src/Makefile.test.include
100

ordering is still wrong. this should come after test/fuzz/FuzzedDataProvider.h \

This revision now requires changes to proceed.Aug 6 2020, 21:24
majcosta updated this revision to Diff 22781.Aug 6 2020, 21:26

fixed order in makefile

majcosta updated this revision to Diff 22782.Aug 6 2020, 21:34

actually fixed it this time

jasonbcox accepted this revision.Aug 6 2020, 21:35
This revision is now accepted and ready to land.Aug 6 2020, 21:35
This revision was landed with ongoing or failed builds.Aug 6 2020, 21:36
Closed by commit rABC3015e8733ec7: [backport#18206] tests: Add fuzzing harness for bloom filter classes… (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC3015e8733ec7: [backport#18206] tests: Add fuzzing harness for bloom filter classes….
Harbormaster completed remote builds in B12325: Diff 22781.Aug 6 2020, 21:41
Harbormaster completed remote builds in B12326: Diff 22782.Aug 6 2020, 21:49

Revision Contents
Changeset List

PathSize
src/
17 lines
test/
fuzz/
2 lines
88 lines
52 lines
43 lines

Diff 22776

View Options

src/Makefile.test.include

Loading...
View Options

src/test/fuzz/CMakeLists.txt

Loading...
View Options

src/test/fuzz/bloom_filter.cpp

Loading...
View Options

src/test/fuzz/rolling_bloom_filter.cpp

Loading...
View Options

src/test/fuzz/util.h

Loading...