Page MenuHomePhabricator

Allow large integers to be used in maxtries
ClosedPublic

Authored by jasonbcox on Aug 6 2020, 00:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1b3695b519a0: Allow large integers to be used in maxtries
Summary

While doing some testing, I ran into this issue.
maxtries is the total number of tries regardless of the number of blocks to generate.
On modern machines, it's trivial to hit the limit when generating hundreds of blocks in
one go. The underlying implementation already supports 64-bit int, so let's use it.

Test Plan
ninja
test_runner.py mining_basic

Diff Detail

Repository
rABC Bitcoin ABC
Branch
large-maxtries
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12318
Build 24832: Build Diffbuild-without-wallet · build-clang-10 · build-clang-tidy · build-diff
Build 24831: arc lint + arc unit