Page MenuHomePhabricator

Add a feed from blog.bitcoinabc.org
ClosedPublic

Authored by jasonbcox on Aug 25 2020, 22:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCWEB18bf62da639a: Add a feed from blog.bitcoinabc.org
Summary

This adds a more prominent blog feed from blog.bitcoinabc.org as the primary article feed.
This enables our content creators to publish content as they are ready rather than pushing them through
tedious code review.

Note that the old "announcements" feed is still present until some of our recent posts have been migrated
to blog.bitcoinabc.org. This feed can be removed once that is completed. Old announcement posts will continue
to exist for posterity.

The Announcements link has been moved out of the nav bar in favor of a more prominent and less confusing link to Blog.

Test Plan

make serve

Diff Detail

Repository
rABCWEB Bitcoin ABC Website
Branch
blog-feed
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12477
Build 25104: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Aug 26 2020, 13:10
deadalnix added a subscriber: deadalnix.

You need to statically render something, you can still update it via JS, but that's not enough.

js/blog-feed.js
1 ↗(On Diff #23037)

This way of doing this without static rendering at any point will make these links invisible to crawlers.

This revision now requires changes to proceed.Aug 26 2020, 13:10

Ensure there is a way to provide static blog feed content to improve SEO.
CI will run this script on every deployment to ensure the content is up-to-date.

Note that this patch does not yet introduce a robust way to automatically
update the static JSON when building locally. This needs to come in a future
patch since the build system is sort of fubared.

deadalnix requested changes to this revision.Aug 28 2020, 17:34
deadalnix added inline comments.
js/blog-feed.js
5

Why wouldn't you just replace the content of the feed? This will duplicate entries.

7

You need to escape these strings.

This revision now requires changes to proceed.Aug 28 2020, 17:34
  • Use jQuery objects instead of plain strings -> HTML
  • Encode all strings from the blog feed
js/blog-feed.js
5

It does precisely this. See the feed.empty() above.

deadalnix added inline comments.
js/blog-feed.js
8 ↗(On Diff #23083)

You can probably do `<a />`

22 ↗(On Diff #23083)

You might want to have prettier format this.

This revision is now accepted and ready to land.Aug 31 2020, 16:17
This revision was automatically updated to reflect the committed changes.