[backport#17342][refactor] Remove global int nScriptCheckThreads
ClosedPublic
Actions

Authored by majcosta on Aug 31 2020, 20:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6b134a6895e1: [backport#17342][refactor] Remove global int nScriptCheckThreads

Summary

The global nScriptCheckThreads int is confusing and is only needed for
its int-ness in AppInitMain. Move all -par parsing logic there and
~~replace~~ remove the int nScriptCheckThreads ~~with a bool g_parallel_script_checks.~~ (see D521)

Also tidy up logic and improve comments.

https://github.com/bitcoin/bitcoin/pull/17342/commits/5506ecfe7a65d5705616bc048f2f1735b89993fb

Concludes backport of Core PR17342

Depends on D7274

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17342

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12505
Build 25145: Build Diff	build-clang-tidy · build-diff · build-clang-10 · build-without-wallet
Build 25144: arc lint + arc unit

Event Timeline

majcosta created this revision.Aug 31 2020, 20:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 31 2020, 20:09

majcosta requested review of this revision.Aug 31 2020, 20:09

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12505: Diff 23099.Aug 31 2020, 20:25

majcosta retitled this revision from [backport#17342][refactor] Replace global int nScriptCheckThreads with bool to [backport#17342][refactor] Remove global int nScriptCheckThreads.Aug 31 2020, 21:58

majcosta edited the summary of this revision. (Show Details)

Fabien accepted this revision.Sep 1 2020, 06:35

This revision is now accepted and ready to land.Sep 1 2020, 06:35

Closed by commit rABC6b134a6895e1: [backport#17342][refactor] Remove global int nScriptCheckThreads (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhySep 1 2020, 12:20

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC6b134a6895e1: [backport#17342][refactor] Remove global int nScriptCheckThreads.