Page MenuHomePhabricator

[backport#17342][refactor] Remove global int nScriptCheckThreads
ClosedPublic

Authored by majcosta on Aug 31 2020, 20:09.

Details

Summary

The global nScriptCheckThreads int is confusing and is only needed for
its int-ness in AppInitMain. Move all -par parsing logic there and
replace remove the int nScriptCheckThreads with a bool g_parallel_script_checks. (see D521)

Also tidy up logic and improve comments.

https://github.com/bitcoin/bitcoin/pull/17342/commits/5506ecfe7a65d5705616bc048f2f1735b89993fb


Concludes backport of Core PR17342

Depends on D7274

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta retitled this revision from [backport#17342][refactor] Replace global int nScriptCheckThreads with bool to [backport#17342][refactor] Remove global int nScriptCheckThreads.Aug 31 2020, 21:58
majcosta edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 1 2020, 06:35