Page MenuHomePhabricator

Always use the parallel check codepath for block validation
ClosedPublic

Authored by deadalnix on Sep 4 2017, 20:23.

Details

Summary

Less codepath, more fun. We also had a bug linked to only one of the two path being tested.

Test Plan

Synced the testnet with -par=0 and -par=1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sickpig added inline comments.
src/validation.cpp
1341 ↗(On Diff #1311)

nit: it is a pretty simple change but I wonder it wouldn't be better to this kind of modifications in a separate diff and for the entire file (there are 22 instances of unsigned int in this file alone)

Accepted modulo the unsigned int unrelated change (but I'm good in either case) .

dagurval requested changes to this revision.Sep 5 2017, 22:27
dagurval added a subscriber: dagurval.

After this chance there is nothing but init.cpp using nScriptCheckThreads. How about making it a local variable there? One less global variable.

This revision now requires changes to proceed.Sep 5 2017, 22:27
deadalnix edited edge metadata.

Rebase.

@dagurval, removing the global variable and querying GetArg instead doesn't make the value any less global.

@dagurval, removing the global variable and querying GetArg instead doesn't make the value any less global.

You'll literally have one less global variable decleration in validation.h.

This revision is now accepted and ready to land.Sep 6 2017, 21:51
This revision was automatically updated to reflect the committed changes.