Page MenuHomePhabricator
Differential D7295

[backport#16944][wallet] add fillPSBT to interface
ClosedPublic
Actions

Authored by majcosta on Sep 1 2020, 15:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5624afe2348d: [backport#16944][wallet] add fillPSBT to interface
Summary

https://github.com/bitcoin/bitcoin/pull/16944/commits/39465d545d521e66bb3accfa788aa94bffaf47eb

Note to reviewers: Original PR has a default SigHashType argument for fillPSBT set in both the declaration and definition, I've removed the default from the definition as it's DRYer and less error-prone that way

Partial backport of Core PR16944

Depends on D7294

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.Sep 1 2020, 15:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2020, 15:52
majcosta requested review of this revision.Sep 1 2020, 15:52
teamcity edited the summary of this revision. (Show Details)Sep 1 2020, 15:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta planned changes to this revision.Sep 1 2020, 15:54
majcosta updated this revision to Diff 23144.Sep 1 2020, 16:14

Leaving the redundant default argument to avoid nasty base/derived class shenaningans

majcosta edited the summary of this revision. (Show Details)Sep 1 2020, 16:14
Harbormaster completed remote builds in B12534: Diff 23144.Sep 1 2020, 16:28
deadalnix accepted this revision.Sep 1 2020, 16:43
This revision is now accepted and ready to land.Sep 1 2020, 16:43
majcosta updated this revision to Diff 24177.Oct 1 2020, 23:26

rebase

majcosta added a child revision: D7727: [backport#16944][gui] watch-only wallet: copy PSBT to clipboard.Oct 1 2020, 23:28
Harbormaster completed remote builds in B13142: Diff 24177.Oct 1 2020, 23:38
Closed by commit rABC5624afe2348d: [backport#16944][wallet] add fillPSBT to interface (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by majcosta). · Explain WhyOct 1 2020, 23:44
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5624afe2348d: [backport#16944][wallet] add fillPSBT to interface.

Revision Contents
Changeset List

PathSize
src/
interfaces/
8 lines
10 lines

Diff 24177

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...