Page MenuHomePhabricator

[backport#16944][wallet] add fillPSBT to interface
ClosedPublic

Authored by majcosta on Sep 1 2020, 15:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5624afe2348d: [backport#16944][wallet] add fillPSBT to interface
Summary

https://github.com/bitcoin/bitcoin/pull/16944/commits/39465d545d521e66bb3accfa788aa94bffaf47eb


Note to reviewers: Original PR has a default SigHashType argument for fillPSBT set in both the declaration and definition, I've removed the default from the definition as it's DRYer and less error-prone that way

Partial backport of Core PR16944

Depends on D7294

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta requested review of this revision.Sep 1 2020, 15:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Leaving the redundant default argument to avoid nasty base/derived class shenaningans

This revision is now accepted and ready to land.Sep 1 2020, 16:43