Page MenuHomePhabricator
Differential D730

Get rid of the seeder's netbase
ClosedPublic
Actions

Authored by deadalnix on Nov 27 2017, 02:03.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGff893b1d7446: Get rid of the seeder's netbase
rABCff893b1d7446: Get rid of the seeder's netbase
Summary

As per title.

Depends on D728

Test Plan

Build and run the seeder.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
killseedernetbase
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1233
Build 1233: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 27 2017, 02:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2017, 02:03
Harbormaster completed remote builds in B1188: Diff 1851.Nov 27 2017, 02:03
deadalnix added a child revision: D732: Delete CSeederHeaderMessage from the seeder and use CHeaderMessage instead.Nov 27 2017, 12:31
deadalnix updated this revision to Diff 1904.Dec 3 2017, 16:11

rebase

Harbormaster completed remote builds in B1226: Diff 1904.Dec 3 2017, 16:11
schancel accepted this revision.Dec 3 2017, 19:22
schancel added inline comments.
src/seeder/bitcoin.cpp
254 ↗(On Diff #1904)

proxyConnectionFailed ?

This revision is now accepted and ready to land.Dec 3 2017, 19:22
deadalnix updated this revision to Diff 1915.Dec 3 2017, 19:27

proxyConnectionFailed

Closed by commit rABCff893b1d7446: Get rid of the seeder's netbase (authored by deadalnix). · Explain WhyDec 3 2017, 19:28
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D4259: Remove strlcpy.h.Oct 16 2019, 00:27
Nico Guiton <nico@bitframe.org> mentioned this in rABC995338aa7108: Remove strlcpy.h.Oct 16 2019, 17:48
nakihito mentioned this in rSTAGING995338aa7108: Remove strlcpy.h.Apr 7 2020, 21:26

Revision Contents
Changeset List

PathSize
src/
2 lines
seeder/
10 lines

Diff 1915

View Options

src/Makefile.am

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/netbase.h

Loading...
View Options

src/seeder/netbase.cpp

Loading...