Make MessageStart a std::array instead of a plain C array.
ClosedPublic
Actions

Authored by deadalnix on Nov 27 2017, 15:13.

Details

Reviewers

schancel
sickpig

Group Reviewers

Restricted Project

Commits

rSTAGING5107050d4b3a: Make MessageStart a std::array instead of a plain C array.
rABC5107050d4b3a: Make MessageStart a std::array instead of a plain C array.

Summary

Type safety.

Test Plan

make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 27 2017, 15:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2017, 15:13

Harbormaster completed remote builds in B1199: Diff 1871.Nov 27 2017, 15:13

Does not apply cleanly

This revision now requires changes to proceed.Dec 2 2017, 04:59

rebase

Harbormaster completed remote builds in B1229: Diff 1908.Dec 3 2017, 16:56

schancel accepted this revision.Dec 3 2017, 20:02

This revision is now accepted and ready to land.Dec 3 2017, 20:02

Closed by commit rABC5107050d4b3a: Make MessageStart a std::array instead of a plain C array. (authored by deadalnix). · Explain WhyDec 3 2017, 22:38

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

8 lines

3 lines

5 lines

20 lines

seeder/

bitcoin.cpp

2 lines

test/

validation_tests.cpp

2 lines

validation.cpp

2 lines

Diff 1919

View Options

src/addrdb.cpp

View Options

src/net_processing.cpp

View Options

src/protocol.h

View Options

src/protocol.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/test/validation_tests.cpp

View Options

Make MessageStart a std::array instead of a plain C array.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1919

src/addrdb.cpp

src/net_processing.cpp

src/protocol.h

src/protocol.cpp

src/seeder/bitcoin.cpp

src/test/validation_tests.cpp

src/validation.cpp

Make MessageStart a std::array instead of a plain C array.
ClosedPublic
Actions

Revision Contents
Changeset List