Page MenuHomePhabricator
Differential D7417

[backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata
ClosedPublic
Actions

Authored by majcosta on Sep 10 2020, 18:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC0b5daf4ba8f8: [backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata
Summary

Pass CTxDestination instead of more ambiguous uint160 hash value. This is more
type safe and more efficient since it avoids doing map lookups that will always
fail and were not done previously before https://github.com/bitcoin/bitcoin/commit/a18edd7b383d667b15b6d4b87aa3a055a9fa5051

Change suggested by Andrew Chow <achow101-github@achow101.com> in
https://github.com/bitcoin/bitcoin/pull/17304#discussion_r340345745 and
https://github.com/bitcoin/bitcoin/pull/17381#issuecomment-549994944

https://github.com/bitcoin/bitcoin/pull/17381/commits/4a0abf694ee10cf186f25a67ca35c3fce0c10874

Depends on D7416

Partial backport of Core PR17381

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 10 2020, 18:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2020, 18:05
majcosta requested review of this revision.Sep 10 2020, 18:05
teamcity edited the summary of this revision. (Show Details)Sep 10 2020, 18:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Sep 10 2020, 18:06
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Harbormaster completed remote builds in B12699: Diff 23433.Sep 10 2020, 18:06
majcosta added a child revision: D7418: [backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method.Sep 10 2020, 18:06
teamcity added a comment.Sep 10 2020, 18:09
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
deadalnix accepted this revision.Sep 10 2020, 22:30
This revision is now accepted and ready to land.Sep 10 2020, 22:30
Closed by commit rABC0b5daf4ba8f8: [backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhySep 11 2020, 15:15
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC0b5daf4ba8f8: [backport#17381 2/5] Pass CTxDestination to ScriptPubKeyMan::GetMetadata.

Revision Contents
Changeset List

PathSize
src/
wallet/
10 lines
5 lines
23 lines

Diff 23452

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...