Differential D7418

[backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool method
ClosedPublic
Actions

Authored by majcosta on Sep 10 2020, 18:06.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCfa3481add57b: [backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool…

Summary

Previous discussion https://github.com/bitcoin/bitcoin/pull/17304#discussion_r340307903

https://github.com/bitcoin/bitcoin/pull/17381/commits/491a599b37f3e3a648e52aebed677ca11b0615e2

Depends on D7417

Partial backport of Core PR17381

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 10 2020, 18:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2020, 18:06

majcosta requested review of this revision.Sep 10 2020, 18:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7419: [backport#17381 4/5] Clean up nested scope in GetReservedDestination.Sep 10 2020, 18:07

Harbormaster completed remote builds in B12700: Diff 23434.Sep 10 2020, 18:21

deadalnix accepted this revision.Sep 10 2020, 22:31

This revision is now accepted and ready to land.Sep 10 2020, 22:31

Closed by commit rABCfa3481add57b: [backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool… (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhySep 11 2020, 15:16

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCfa3481add57b: [backport#17381 3/5] Get rid of confusing LegacyScriptPubKeyMan::TopUpKeyPool….

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

1 line

scriptpubkeyman.cpp

16 lines

Diff 23453

View Options

src/wallet/scriptpubkeyman.h