Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC709706b9d79f: [backport#17381 4/5] Clean up nested scope in GetReservedDestination

Summary

Suggested https://github.com/bitcoin/bitcoin/pull/17304#discussion_r341194391
by Gregory Sanders <gsanders87@gmail.com>

Reason for keeping the return true return false verbosity is that more code
will be added after the ReserveKeyFromKeyPool() call before returning.

https://github.com/bitcoin/bitcoin/pull/17381/commits/bfd826a675445801adec86a469040f3ceb8172ee

Depends on D7418

Partial backport of Core PR17381

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 10 2020, 18:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2020, 18:07

majcosta requested review of this revision.Sep 10 2020, 18:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7420: [backport#17381 5/5] Add missing SetupGeneration error handling in EncryptWallet.Sep 10 2020, 18:08

Harbormaster completed remote builds in B12701: Diff 23435.Sep 10 2020, 18:19

deadalnix accepted this revision.Sep 10 2020, 22:31

This revision is now accepted and ready to land.Sep 10 2020, 22:31

Closed by commit rABC709706b9d79f: [backport#17381 4/5] Clean up nested scope in GetReservedDestination (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhySep 11 2020, 15:16

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC709706b9d79f: [backport#17381 4/5] Clean up nested scope in GetReservedDestination.

[backport#17381 4/5] Clean up nested scope in GetReservedDestination
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 23454

src/wallet/scriptpubkeyman.cpp

[backport#17381 4/5] Clean up nested scope in GetReservedDestinationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23454

src/wallet/scriptpubkeyman.cpp

[backport#17381 4/5] Clean up nested scope in GetReservedDestination
ClosedPublic
Actions

Revision Contents
Changeset List