Differential D7507

[backport#15931 2/9] Add m_last_block_processed_height field in CWallet
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 01:17.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC9f81ae2a5b9e: [backport#15931 2/9] Add m_last_block_processed_height field in CWallet

Summary

At BlockConnected/BlockDisconnected, we rely on height of block
itself to know current height of wallet

https://github.com/bitcoin/bitcoin/pull/15931/commits/5aacc3eff15b9b5bdc951f1e274f00d581f63bce

Depends on D7506

Partial backport of Core PR15931

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 22 2020, 01:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 01:17

majcosta requested review of this revision.Sep 22 2020, 01:17

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12836: Diff 23647.Sep 22 2020, 01:26

deadalnix accepted this revision.Sep 22 2020, 01:49

This revision is now accepted and ready to land.Sep 22 2020, 01:49

majcosta added a child revision: D7508: [backport#15931 3/9] Replace CWalletTx::SetConf by Confirmation initialization list.Sep 22 2020, 01:53

Closed by commit rABC9f81ae2a5b9e: [backport#15931 2/9] Add m_last_block_processed_height field in CWallet (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 22 2020, 14:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC9f81ae2a5b9e: [backport#15931 2/9] Add m_last_block_processed_height field in CWallet.

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

wallettests.cpp

3 lines

wallet/

test/

wallet_tests.cpp

30 lines

wallet.h

27 lines

wallet.cpp

8 lines

Diff 23671

View Options

src/qt/test/wallettests.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/wallet.h

View Options

[backport#15931 2/9] Add m_last_block_processed_height field in CWalletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23671

src/qt/test/wallettests.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

[backport#15931 2/9] Add m_last_block_processed_height field in CWallet
ClosedPublic
Actions

Revision Contents
Changeset List