Page MenuHomePhabricator
Differential D7513

[backport#15931 8/9] Remove locked_chain from GetDepthInMainChain and its callers
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 03:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe0ba693ad5f7: [backport#15931 8/9] Remove locked_chain from GetDepthInMainChain and its…
Summary

We don't remove yet Chain locks as we need to preserve lock
order with CWallet one until swapping at once to avoid
deadlock failures (spotted by --enable-debug)

https://github.com/bitcoin/bitcoin/pull/15931/commits/b66c429c56c85fa16c309be0b2bca9c25fdd3e1a

Depends on D7512

Partial backport of PR15931

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 22 2020, 03:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 03:52
majcosta requested review of this revision.Sep 22 2020, 03:52
teamcity edited the summary of this revision. (Show Details)Sep 22 2020, 03:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12843: Diff 23655.Sep 22 2020, 03:59
majcosta added a child revision: D7514: [backport#15931 9/9] Remove getBlockDepth method from Chain::interface.Sep 22 2020, 04:05
Fabien accepted this revision.Sep 22 2020, 06:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcwallet.cpp
1878 ↗(On Diff #23655)

You're missing a dependency on https://github.com/bitcoin/bitcoin/pull/17258/files

Edit: Looking closer the dependency can be added after this is landed

This revision is now accepted and ready to land.Sep 22 2020, 06:37
Closed by commit rABCe0ba693ad5f7: [backport#15931 8/9] Remove locked_chain from GetDepthInMainChain and its… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 22 2020, 15:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe0ba693ad5f7: [backport#15931 8/9] Remove locked_chain from GetDepthInMainChain and its….

Revision Contents
Changeset List

PathSize
src/
interfaces/
38 lines
wallet/
6 lines
23 lines
test/
4 lines
35 lines
109 lines

Diff 23677

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...