Differential D7512

[backport#15931 7/9] Use CWallet::m_last_block_processed_height in GetDepthInMainChain
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 03:24.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC169f65bc5d46: [backport#15931 7/9] Use CWallet::m_last_block_processed_height in…

Summary

Avoid to lock chain to query state thanks to tracking last block
height in CWallet.

https://github.com/bitcoin/bitcoin/pull/15931/commits/0ff03871add000f8b4d8f82aeb168eed2fc9dc5f

Depends on D7511

Partial backport of Core PR15931

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Sep 22 2020, 03:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 03:24

majcosta requested review of this revision.Sep 22 2020, 03:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12842: Diff 23654.Sep 22 2020, 03:33

majcosta added a child revision: D7513: [backport#15931 8/9] Remove locked_chain from GetDepthInMainChain and its callers.Sep 22 2020, 03:52

Fabien accepted this revision.Sep 22 2020, 06:21

This revision is now accepted and ready to land.Sep 22 2020, 06:21

Closed by commit rABC169f65bc5d46: [backport#15931 7/9] Use CWallet::m_last_block_processed_height in… (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 22 2020, 14:59

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC169f65bc5d46: [backport#15931 7/9] Use CWallet::m_last_block_processed_height in….

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

9 lines

wallet.cpp

4 lines

Diff 23676

View Options

src/wallet/wallet.h