Page MenuHomePhabricator

[CI] Run the circular dependencies linter on CI for each diff
ClosedPublic

Authored by Fabien on Sep 23 2020, 06:58.

Details

Summary

Follow-up for the discussion in D7458.

The circular dependencies linter takes too long to run to be integrated
as part of the regular linter test suite (from 2.5s to 6s on my
machines). This diffs adds it to the CI configurations that will run for
every diff. The script is adapted to always run from the project root
and bail out early on failure.

Depends on D7534.

Test Plan
./contrib/teamcity/build-configurations.py lint-circular-dependencies

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ci_circular_dependencies
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12879
Build 25825: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 25824: arc lint + arc unit