Page MenuHomePhabricator
Differential D7582

[backport#16443 3/3] Cover UTXO set access with lock annotations
ClosedPublic
Actions

Authored by majcosta on Sep 27 2020, 20:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC124054fe2dc7: [backport#16443 3/3] Cover UTXO set access with lock annotations
Summary

i.e. any CoinsViews members. Adds a lock acquisition to gettxoutsetinfo RPC
to comply with added annotations.

Co-authored-by: Russell Yanofsky <russ@yanofsky.org>

https://github.com/bitcoin/bitcoin/pull/16443/commits/582d2cd74754d6b9a2394616a9c82a89d2d71976

Depends on D7581

Concludes backport of Core PR16443

Test Plan
cmake .. -DENABLE_SANITIZERS=address
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 27 2020, 20:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2020, 20:52
majcosta requested review of this revision.Sep 27 2020, 20:52
teamcity edited the summary of this revision. (Show Details)Sep 27 2020, 20:52

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12944: Diff 23834.Sep 27 2020, 21:00
deadalnix accepted this revision.Sep 27 2020, 22:10
This revision is now accepted and ready to land.Sep 27 2020, 22:10
Closed by commit rABC124054fe2dc7: [backport#16443 3/3] Cover UTXO set access with lock annotations (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhyOct 15 2020, 23:58
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC124054fe2dc7: [backport#16443 3/3] Cover UTXO set access with lock annotations.
PiRK mentioned this in D12915: Add missing thread safety lock assertions in validation.{h|cpp}.Dec 19 2022, 11:11
PiRK mentioned this in rABC7c8d98584d33: Add missing thread safety lock assertions in validation.{h|cpp}.Dec 19 2022, 13:57

Revision Contents
Changeset List

PathSize
src/
7 lines
rpc/
5 lines
test/
1 line
2 lines
17 lines
3 lines

Diff 23834

View Options

src/init.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...