Differential D7656

Make secp256k1_scalar_b32 detect overflow in scalar_low
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 12:43.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCef5bb90888c0: Make secp256k1_scalar_b32 detect overflow in scalar_low

Summary

This is a partial backport of secp256k1 PR808 : https://github.com/bitcoin-core/secp256k1/pull/808/commits/8bcd78cd791fd9209d72d6bce455c8d3cf2c0249

Depends on D7655

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 12:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 12:43

deadalnix requested review of this revision.Sep 29 2020, 12:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D7657: Delete gej_is_valid_var: unused outside tests.Sep 29 2020, 12:44

Fabien accepted this revision.Sep 29 2020, 12:58

This revision is now accepted and ready to land.Sep 29 2020, 12:58

Harbormaster completed remote builds in B13038: Diff 23997.Sep 29 2020, 13:03

Closed by commit rABCef5bb90888c0: Make secp256k1_scalar_b32 detect overflow in scalar_low (authored by Pieter Wuille <pieter@wuille.net>, committed by deadalnix). · Explain WhySep 29 2020, 13:04

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCef5bb90888c0: Make secp256k1_scalar_b32 detect overflow in scalar_low.

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

modules/

recovery/

tests_exhaustive_impl.h

16 lines

scalar_low_impl.h

11 lines

Diff 24014

View Options

src/secp256k1/src/modules/recovery/tests_exhaustive_impl.h