Differential D7666

Abstract out challenge computation in schnorrsig
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 12:59.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC175e3ee20f2c: Abstract out challenge computation in schnorrsig

Summary

This is a partial backport of secp256k1 PR808 : https://github.com/bitcoin-core/secp256k1/pull/808/commits/87af00b511f2938b6b4799f94d446a005730515e

Depends on D7665

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 12:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 13:00

deadalnix requested review of this revision.Sep 29 2020, 13:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D7667: Make pubkey parsing test whether points are in the correct subgroup.Sep 29 2020, 13:01

Fabien accepted this revision.Sep 29 2020, 13:18

This revision is now accepted and ready to land.Sep 29 2020, 13:18

This revision was landed with ongoing or failed builds.Sep 29 2020, 13:31

Closed by commit rABC175e3ee20f2c: Abstract out challenge computation in schnorrsig (authored by Pieter Wuille <pieter@wuille.net>, committed by deadalnix). · Explain Why

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC175e3ee20f2c: Abstract out challenge computation in schnorrsig.

Harbormaster completed remote builds in B13048: Diff 24008.Sep 29 2020, 13:43

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

modules/

schnorrsig/

main_impl.h

37 lines

Diff 24027

View Options

src/secp256k1/src/modules/schnorrsig/main_impl.h

Abstract out challenge computation in schnorrsigClosedPublicActions