Page MenuHomePhabricator
Differential D7660

Change exhaustive test groups so they have a point with X=1
ClosedPublic
Actions

Authored by deadalnix on Sep 29 2020, 12:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4d157a325167: Change exhaustive test groups so they have a point with X=1
Summary

This enables testing overflow is correctly encoded in the recid, and
likely triggers more edge cases.

Also introduce a Sage script to generate the parameters.

This is a partial backport of secp256k1 PR808 : https://github.com/bitcoin-core/secp256k1/pull/808/commits/b110c106fa9704e30f6b0c2ffa6a2697031e89a8

Depends on D7659

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 29 2020, 12:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2020, 12:49
deadalnix requested review of this revision.Sep 29 2020, 12:49
teamcity edited the summary of this revision. (Show Details)Sep 29 2020, 12:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a child revision: D7662: refactor: move RNG seeding to testrand.Sep 29 2020, 12:51
Fabien accepted this revision.Sep 29 2020, 13:08
This revision is now accepted and ready to land.Sep 29 2020, 13:08
This revision was landed with ongoing or failed builds.Sep 29 2020, 13:14
Closed by commit rABC4d157a325167: Change exhaustive test groups so they have a point with X=1 (authored by Pieter Wuille <pieter@wuille.net>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4d157a325167: Change exhaustive test groups so they have a point with X=1.
Harbormaster completed remote builds in B13042: Diff 24002.Sep 29 2020, 13:22

Revision Contents
Changeset List

PathSize
src/
secp256k1/
sage/
129 lines
src/
64 lines
modules/
recovery/
12 lines
1 line
8 lines

Diff 24019

View Options

src/secp256k1/sage/gen_exhaustive_groups.sage

Loading...
View Options

src/secp256k1/src/group_impl.h

Loading...
View Options

src/secp256k1/src/modules/recovery/tests_exhaustive_impl.h

Loading...
View Options

src/secp256k1/src/scalar_impl.h

Loading...
View Options

src/secp256k1/src/tests_exhaustive.c

Loading...