Page MenuHomePhabricator
Differential D7837

[backport#17261 1/13] wallet: Improve CWallet:MarkDestinationsDirty
AbandonedPublic
Actions

Authored by majcosta on Oct 9 2020, 03:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

https://github.com/bitcoin/bitcoin/pull/17261/commits/f5be479694d4dbaf59eef562d80fbeacb3bb7dc1

Note: apparently this commit was already done in its own PR??? https://github.com/bitcoin/bitcoin/pull/17621/files

Partial backport of Core PR17261

Test Plan
ninja

Diff Detail

Event Timeline

majcosta created this revision.Oct 9 2020, 03:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 03:26
majcosta requested review of this revision.Oct 9 2020, 03:26
teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 03:26
majcosta added a child revision: D7838: [backport#17261 2/13] Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman.Oct 9 2020, 03:27
Harbormaster completed remote builds in B13287: Diff 24433.Oct 9 2020, 03:35
Fabien requested changes to this revision.Oct 9 2020, 06:32
Fabien added a subscriber: Fabien.

You should just skip this commit. Unless you really have a need for removing this newline (which is not part of the PR), this only adds an empty commit with a non matching description to our history.
You should take a look at the actual git history and not only the github display since it seems to have a bug with that PR (and it cannot display find the merge commit).

This revision now requires changes to proceed.Oct 9 2020, 06:32
majcosta abandoned this revision.Oct 9 2020, 13:42

yea, good point. abandoning this.

Revision Contents
Changeset List

PathSize
src/
wallet/
1 line

Diff 24433

View Options

src/wallet/wallet.cpp

Loading...