Differential D7860

[backport#17261 11/13] Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan
ClosedPublic
Actions

Authored by majcosta on Oct 9 2020, 18:20.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC0345bf880594: [backport#17261 11/13] Refactor: Copy CWallet signals and print function to…

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17261/commits/e2f02aa59e3402048269362ff692d49a6df35cfd

Depends on D7859

Partial backport of Core PR17261

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 9 2020, 18:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 18:20

majcosta requested review of this revision.Oct 9 2020, 18:20

teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 18:20

majcosta added a child revision: D7861: [backport#17261 12/13] Cleanup: Drop unused GUI learnRelatedScripts method.Oct 9 2020, 18:26

Harbormaster completed remote builds in B13319: Diff 24482.Oct 9 2020, 18:28

deadalnix accepted this revision.Oct 9 2020, 22:25

This revision is now accepted and ready to land.Oct 9 2020, 22:25

Closed by commit rABC0345bf880594: [backport#17261 11/13] Refactor: Copy CWallet signals and print function to… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyOct 10 2020, 19:48

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC0345bf880594: [backport#17261 11/13] Refactor: Copy CWallet signals and print function to….

Revision Contents
Changeset List

Path

Size

src/

wallet/

26 lines

17 lines

3 lines

9 lines

test/

lint/

lint-circular-dependencies.sh

1 line

lint-format-strings.py

7 lines

Diff 24509

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

src/wallet/wallet.h

View Options

src/wallet/wallet.cpp

View Options

test/lint/lint-circular-dependencies.sh

View Options

test/lint/lint-format-strings.py

[backport#17261 11/13] Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyManClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24509

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

test/lint/lint-circular-dependencies.sh

test/lint/lint-format-strings.py

[backport#17261 11/13] Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan
ClosedPublic
Actions

Revision Contents
Changeset List