Page MenuHomePhabricator
Differential D7850

[backport#17261 5/13] Always try to sign for all pubkeys in multisig
ClosedPublic
Actions

Authored by majcosta on Oct 9 2020, 14:57.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC82c314ca28b9: [backport#17261 5/13] Always try to sign for all pubkeys in multisig
Summary

https://github.com/bitcoin/bitcoin/pull/17261/commits/501acb5538008d98abe79288b92040bc186b93f3

Depends on D7849

Partial backport of Core PR17261

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 9 2020, 14:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2020, 14:57
majcosta requested review of this revision.Oct 9 2020, 14:57
teamcity edited the summary of this revision. (Show Details)Oct 9 2020, 14:58
majcosta added a child revision: D7851: [backport#17261 6/13] Store p2sh scripts in AddAndGetDestinationForScript.Oct 9 2020, 14:59
Harbormaster completed remote builds in B13302: Diff 24459.Oct 9 2020, 15:05
teamcity added a comment.Oct 9 2020, 15:05
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[309/485] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[310/485] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[311/485] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[312/485] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[313/485] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[314/485] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o
[315/485] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[316/485] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[317/485] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[318/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[319/485] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[320/485] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[321/485] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[322/485] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[323/485] Linking C static library src/secp256k1/libsecp256k1.a
[324/485] Linking C executable src/secp256k1/ecmult-bench
[325/485] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[326/485] Linking C executable src/secp256k1/internal-bench
[327/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[328/485] Linking C executable src/secp256k1/sign-bench
[329/485] Linking C executable src/secp256k1/verify-bench
[330/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[331/485] Linking C executable src/secp256k1/recover-bench
[332/485] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[333/485] Linking CXX static library src/libscript.a
[334/485] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[335/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[336/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[337/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[338/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[339/485] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[340/485] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[341/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[342/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[343/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[344/485] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[345/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/psbtwallet.cpp.o
[346/485] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[347/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[348/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[349/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[350/485] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[351/485] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[352/485] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[353/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[354/485] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[355/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[356/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[357/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[358/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[359/485] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Oct 9 2020, 15:06
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[284/434] Building CXX object src/CMakeFiles/server.dir/policy/settings.cpp.o
[285/434] Building CXX object src/CMakeFiles/server.dir/node/psbt.cpp.o
[286/434] Building CXX object src/CMakeFiles/server.dir/pow/daa.cpp.o
[287/434] Building CXX object src/CMakeFiles/server.dir/pow/eda.cpp.o
[288/434] Building CXX object src/CMakeFiles/server.dir/miner.cpp.o
[289/434] Building CXX object src/CMakeFiles/server.dir/rpc/command.cpp.o
[290/434] Building CXX object src/CMakeFiles/server.dir/noui.cpp.o
[291/434] Building CXX object src/CMakeFiles/server.dir/pow/pow.cpp.o
[292/434] Building CXX object src/CMakeFiles/server.dir/node/coinstats.cpp.o
[293/434] Building CXX object src/CMakeFiles/server.dir/pow/aserti32d.cpp.o
[294/434] Building CXX object src/CMakeFiles/server.dir/node/transaction.cpp.o
[295/434] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[296/434] Building CXX object src/CMakeFiles/server.dir/shutdown.cpp.o
[297/434] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[298/434] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[299/434] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[300/434] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[301/434] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[302/434] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[303/434] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[304/434] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[305/434] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[306/434] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[307/434] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[308/434] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[309/434] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[310/434] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[311/434] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[312/434] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[313/434] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[314/434] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[315/434] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[316/434] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[317/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[318/434] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[319/434] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[320/434] Linking C static library src/secp256k1/libsecp256k1.a
[321/434] Linking C executable src/secp256k1/ecmult-bench
[322/434] Linking C executable src/secp256k1/internal-bench
[323/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[324/434] Linking C executable src/secp256k1/sign-bench
[325/434] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[326/434] Linking C executable src/secp256k1/verify-bench
[327/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[328/434] Linking C executable src/secp256k1/recover-bench
[329/434] Building CXX object src/seeder/CMakeFiles/seeder.dir/dns.cpp.o
[330/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[331/434] Building CXX object src/seeder/CMakeFiles/seeder.dir/bitcoin.cpp.o
[332/434] Building CXX object src/seeder/CMakeFiles/seeder.dir/db.cpp.o
[333/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[334/434] Building CXX object src/CMakeFiles/server.dir/ui_interface.cpp.o
[335/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[336/434] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[337/434] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[338/434] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[339/434] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[340/434] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[341/434] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
majcosta updated this revision to Diff 24474.Oct 9 2020, 16:40

rebase

majcosta updated this revision to Diff 24475.Oct 9 2020, 16:42

rebase

Harbormaster completed remote builds in B13312: Diff 24474.Oct 9 2020, 17:02
Harbormaster completed remote builds in B13313: Diff 24475.Oct 9 2020, 17:07
deadalnix accepted this revision.Oct 9 2020, 21:50
This revision is now accepted and ready to land.Oct 9 2020, 21:50
majcosta updated this revision to Diff 24494.Oct 10 2020, 17:44

rebase

Harbormaster completed remote builds in B13329: Diff 24494.Oct 10 2020, 18:02
Closed by commit rABC82c314ca28b9: [backport#17261 5/13] Always try to sign for all pubkeys in multisig (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyOct 10 2020, 19:31
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC82c314ca28b9: [backport#17261 5/13] Always try to sign for all pubkeys in multisig.

Revision Contents
Changeset List

PathSize
src/
script/
11 lines

Diff 24503

View Options

src/script/sign.cpp

Loading...