Page MenuHomePhabricator

Don't enforce xvfb for generating the man pages
ClosedPublic

Authored by Fabien on Wed, Oct 14, 10:12.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC6e0155272e71: Don't enforce xvfb for generating the man pages
Summary

D7677 made it mandatory to use xvfb for generating the man pages. This
causes a few issues:

  • It enforces installing xvfb which comes with a lot of dependencies, even if bitcoin-qt is not built.
  • xvfb-run is not designed to run parallel, and will fail on some systems due to race when running ninja install-manpages (even with the -a flag).

This diff removes the mandatory xvfb and adds a README to instruct the
user that it might be required and how to install it.

Test Plan

Read and try the instructions.

./contrib/teamcity/build-configurations.py build-docs

On Archlinux:

ninja install-manpages

Should no longer fail.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.