Page MenuHomePhabricator

rpc: Auto-format RPCResult
ClosedPublic

Authored by deadalnix on Oct 26 2020, 15:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC119798507329: rpc: Auto-format RPCResult
Summary
Test Plan
ninja all check-all

Examine the differential in documentation to ensure it is correct: https://reviews.bitcoinabc.org/differential/diff/25141/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Oct 26 2020, 15:45
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/blockchain.cpp
1741 ↗(On Diff #25113)

Revert

src/rpc/mining.cpp
484 ↗(On Diff #25113)

Revert

src/rpc/net.cpp
105 ↗(On Diff #25113)

Revert

633 ↗(On Diff #25113)

Revert and restore excessutxocharge

src/rpc/rawtransaction.cpp
118 ↗(On Diff #25113)

Not from this diff, but can be fixed here

573 ↗(On Diff #25113)

Dito

1220 ↗(On Diff #25113)

Revert

src/wallet/rpcwallet.cpp
3481 ↗(On Diff #25113)

Missing newline

4292 ↗(On Diff #25113)

Revert

4296 ↗(On Diff #25113)

Revert

This revision now requires changes to proceed.Oct 26 2020, 15:45

Address comments and update the diff in the test plan.

Fabien added inline comments.
src/rpc/rawtransaction.cpp
573 ↗(On Diff #25113)

This one has not been addressed but is not introduced in this diff, up to you

This revision is now accepted and ready to land.Oct 27 2020, 07:21
This revision was automatically updated to reflect the committed changes.