Differential D8124

rpc: Auto-format RPCResult
ClosedPublic
Actions

Authored by deadalnix on Oct 26 2020, 15:20.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC119798507329: rpc: Auto-format RPCResult

Summary

Backport of Core PR17809 part [2/2] : https://github.com/bitcoin/bitcoin/pull/17809/commits/fa6b061fc118995eec41766519a11bc0dd1a901d

Depends on D8123

Test Plan

ninja all check-all

Examine the differential in documentation to ensure it is correct: https://reviews.bitcoinabc.org/differential/diff/25141/

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 26 2020, 15:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2020, 15:20

deadalnix requested review of this revision.Oct 26 2020, 15:20

teamcity edited the summary of this revision. (Show Details)Oct 26 2020, 15:20

Harbormaster completed remote builds in B13680: Diff 25113.Oct 26 2020, 15:36

Fabien requested changes to this revision.Oct 26 2020, 15:45

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/rpc/blockchain.cpp
1741 ↗	(On Diff #25113)	Revert
src/rpc/mining.cpp
484 ↗	(On Diff #25113)	Revert
src/rpc/net.cpp
105 ↗	(On Diff #25113)	Revert
633 ↗	(On Diff #25113)	Revert and restore excessutxocharge
src/rpc/rawtransaction.cpp
118 ↗	(On Diff #25113)	Not from this diff, but can be fixed here
573 ↗	(On Diff #25113)	Dito
1220 ↗	(On Diff #25113)	Revert
src/wallet/rpcwallet.cpp
3481 ↗	(On Diff #25113)	Missing newline
4292 ↗	(On Diff #25113)	Revert
4296 ↗	(On Diff #25113)	Revert

This revision now requires changes to proceed.Oct 26 2020, 15:45

deadalnix edited the test plan for this revision. (Show Details)Oct 26 2020, 22:52

Address comments and update the diff in the test plan.

Harbormaster completed remote builds in B13694: Diff 25142.Oct 26 2020, 23:22

Fabien accepted this revision.Oct 27 2020, 07:21

Fabien added inline comments.

src/rpc/rawtransaction.cpp
573 ↗	(On Diff #25113)	This one has not been addressed but is not introduced in this diff, up to you

This revision is now accepted and ready to land.Oct 27 2020, 07:21

Closed by commit rABC119798507329: rpc: Auto-format RPCResult (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyOct 27 2020, 12:53

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC119798507329: rpc: Auto-format RPCResult.

PiRK mentioned this in D8275: refactor: Remove unused COINBASE_FLAGS.Nov 5 2020, 09:49

PiRK mentioned this in rABC09759c8f876e: refactor: Remove unused COINBASE_FLAGS.Nov 5 2020, 11:59

Revision Contents
Changeset List

Path

Size

src/

rpc/

4 lines

8 lines

1040 lines

243 lines

146 lines

432 lines

rawtransaction.cpp

782 lines

39 lines

68 lines

102 lines

wallet/

45 lines

1277 lines

zmq/

24 lines

Diff 25146

src/rpc/abc.cpp

Loading...

src/rpc/avalanche.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/server.cpp

Loading...

src/rpc/util.h

Loading...

src/rpc/util.cpp

Loading...

src/wallet/rpcdump.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/zmq/zmqrpc.cpp

Loading...