Differential D8155

util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.
ClosedPublic
Actions

Authored by Fabien on Oct 28 2020, 13:23.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC378e5385a539: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded…

Summary

Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded
NUL characters. Add tests.

Backport of core PR17753.

Depends on D8154.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17753

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13716
Build 27452: Build Diff	build-clang-tidy · lint-circular-dependencies · build-clang · build-diff · build-debug · build-without-wallet
Build 27451: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 28 2020, 13:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 28 2020, 13:23

Fabien requested review of this revision.Oct 28 2020, 13:23

teamcity edited the summary of this revision. (Show Details)Oct 28 2020, 13:24

Fabien added a child revision: D8156: tests: Add fuzzing harnesses for various Base{32,58,64} and hex related functions.Oct 28 2020, 13:28

Harbormaster completed remote builds in B13716: Diff 25177.Oct 28 2020, 13:37

deadalnix accepted this revision.Oct 28 2020, 13:45

This revision is now accepted and ready to land.Oct 28 2020, 13:45

Closed by commit rABC378e5385a539: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyOct 28 2020, 13:59

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC378e5385a539: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded….

Revision Contents
Changeset List

Path

Size

src/

test/

base32_tests.cpp

11 lines

base64_tests.cpp

11 lines

util_tests.cpp

5 lines

util/

moneystr.cpp

4 lines

strencodings.cpp

12 lines

Diff 25177

View Options

src/test/base32_tests.cpp

View Options

src/test/base64_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/util/moneystr.cpp

View Options

util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25177

src/test/base32_tests.cpp

src/test/base64_tests.cpp

src/test/util_tests.cpp

src/util/moneystr.cpp

src/util/strencodings.cpp

util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.
ClosedPublic
Actions

Revision Contents
Changeset List