Page MenuHomePhabricator
Differential D8195

Integrate ASN bucketing in Addrman and add tests
ClosedPublic
Actions

Authored by Fabien on Oct 30 2020, 14:25.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCff7f19b6fce1: Integrate ASN bucketing in Addrman and add tests
Summary
Instead of using /16 netgroups to bucket nodes in Addrman for connection
diversification, ASN, which better represents an actor in terms
of network-layer infrastructure, is used.
For testing, asmap.raw is used. It represents a minimal
asmap needed for testing purposes.

Partial backport 2/4 of core PR16702:
https://github.com/bitcoin/bitcoin/pull/16702/commits/ec45646de9e62b3d42c85716bfeb06d8f2b507dc

Depends on D8194.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 30 2020, 14:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2020, 14:25
Fabien requested review of this revision.Oct 30 2020, 14:25
teamcity edited the summary of this revision. (Show Details)Oct 30 2020, 14:25
Fabien added a child revision: D8196: Return mapped AS in RPC call getpeerinfo.Oct 30 2020, 14:28
Harbormaster completed remote builds in B13768: Diff 25272.Oct 30 2020, 14:40
jasonbcox accepted this revision.Oct 30 2020, 16:43
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/test/data/generate_asmap.py
22 ↗(On Diff #25272)

Sorry to bust the easter egg, but this isn't very informative. lol

This revision is now accepted and ready to land.Oct 30 2020, 16:43
Fabien updated this revision to Diff 25284.Oct 30 2020, 19:14

Remove easter egg

This revision was landed with ongoing or failed builds.Oct 30 2020, 19:20
Closed by commit rABCff7f19b6fce1: Integrate ASN bucketing in Addrman and add tests (authored by Gleb Naumenko <naumenko.gs@gmail.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCff7f19b6fce1: Integrate ASN bucketing in Addrman and add tests.
Harbormaster completed remote builds in B13777: Diff 25284.Oct 30 2020, 19:26

Revision Contents
Changeset List

PathSize
src/
117 lines
58 lines
30 lines
3 lines
7 lines
2 lines
24 lines
test/
28 lines
320 lines
data/
26 lines
34 lines

Diff 25287

View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/addrman_tests.cpp

Loading...
View Options

src/test/data/asmap.raw

Loading...
View Options

src/test/data/generate_asmap.py

Loading...
View Options

src/test/netbase_tests.cpp

Loading...