Differential D8200

config, net, test: asmap feature refinements and functional tests
ClosedPublic
Actions

Authored by Fabien on Oct 30 2020, 16:21.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC930510cbf4cd: config, net, test: asmap feature refinements and functional tests

Summary

This PR builds on PR #16702 to add functional tests / sanity checks and
user-facing refinements for passing -asmap to configure ASN-based IP
bucketing in addrman. As per our review discussion in that PR, the idea
here is to handle aspects like functional tests and config arg handling
that can help the PR be merged while enabling the author to focus on the
bucketing itself.

Backport of core PR17812.

Depends on D8198.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 30 2020, 16:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2020, 16:21

Fabien requested review of this revision.Oct 30 2020, 16:21

teamcity edited the summary of this revision. (Show Details)Oct 30 2020, 16:21

Fabien added inline comments.Oct 30 2020, 16:25

src/netaddress.h
42 ↗	(On Diff #25277)	Note to reviewers: this change is extracted from PR18029 which will be ported soon. I wanted to get all the fixes before the fuzzer gets added.