Page MenuHomePhabricator
Differential D8198

Fix some asmap issues
ClosedPublic
Actions

Authored by Fabien on Oct 30 2020, 15:00.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCe4c59a238266: Fix some asmap issues
Summary
Here are a few things to improve in the asmap implementation. The first
two commits are just code improvements. The last one is a bugfix (the
exsting code wouldn't correctly apply ASN lookups to mapped/embedded
IPv4 addresses).

Backport of core PR18023.

Depends on D8197.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 30 2020, 15:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2020, 15:00
Fabien requested review of this revision.Oct 30 2020, 15:00
teamcity edited the summary of this revision. (Show Details)Oct 30 2020, 15:00
Harbormaster completed remote builds in B13771: Diff 25275.Oct 30 2020, 15:10
Fabien added a child revision: D8200: config, net, test: asmap feature refinements and functional tests.Oct 30 2020, 16:21
jasonbcox requested changes to this revision.Oct 30 2020, 18:10
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/netaddress.cpp
513 ↗(On Diff #25275)

missed if -> else if

This revision now requires changes to proceed.Oct 30 2020, 18:10
Fabien updated this revision to Diff 25285.Oct 30 2020, 19:15

if => else if

jasonbcox accepted this revision.Oct 30 2020, 19:16
This revision is now accepted and ready to land.Oct 30 2020, 19:16
This revision was landed with ongoing or failed builds.Oct 30 2020, 19:24
Closed by commit rABCe4c59a238266: Fix some asmap issues (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe4c59a238266: Fix some asmap issues.
Harbormaster completed remote builds in B13778: Diff 25285.Oct 30 2020, 19:52

Revision Contents
Changeset List

PathSize
src/
2 lines
6 lines
2 lines
6 lines
71 lines
util/
60 lines

Diff 25291

View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/util/asmap.cpp

Loading...