Page MenuHomePhabricator

Fix some asmap issues
ClosedPublic

Authored by Fabien on Oct 30 2020, 15:00.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCe4c59a238266: Fix some asmap issues
Summary
Here are a few things to improve in the asmap implementation. The first
two commits are just code improvements. The last one is a bugfix (the
exsting code wouldn't correctly apply ASN lookups to mapped/embedded
IPv4 addresses).

Backport of core PR18023.

Depends on D8197.

Test Plan
ninja all check-all

Event Timeline

Fabien requested review of this revision.Oct 30 2020, 15:00
jasonbcox requested changes to this revision.Oct 30 2020, 18:10
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/netaddress.cpp
513 ↗(On Diff #25275)

missed if -> else if

This revision now requires changes to proceed.Oct 30 2020, 18:10
This revision is now accepted and ready to land.Oct 30 2020, 19:16
This revision was landed with ongoing or failed builds.Oct 30 2020, 19:24
This revision was automatically updated to reflect the committed changes.