Differential D8209

[backport#12204] Fix overly eager BIP30 bypass
ClosedPublic
Actions

Authored by majcosta on Oct 31 2020, 02:43.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4a728f1473e1: [backport#12204] Fix overly eager BIP30 bypass

Summary

5b8b38775 Fix overly eager BIP30 bypass (Alex Morcos)

Pull request description:

In #6931 we introduced a possible consensus breaking change by misunderstanding how completely BIP 34 obviated the need for BIP 30.  Unfixed, this could break consensus after block height about 1.9M.  Explained in code comment.

h/t @sdaftuar

Backport of Core PR12204

Test Plan

ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 31 2020, 02:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2020, 02:43

majcosta requested review of this revision.Oct 31 2020, 02:43

teamcity edited the summary of this revision. (Show Details)Oct 31 2020, 02:43

Harbormaster completed remote builds in B13786: Diff 25302.Oct 31 2020, 02:51

PiRK accepted this revision.Oct 31 2020, 07:33

This revision is now accepted and ready to land.Oct 31 2020, 07:33

Closed by commit rABC4a728f1473e1: [backport#12204] Fix overly eager BIP30 bypass (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyOct 31 2020, 20:15

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC4a728f1473e1: [backport#12204] Fix overly eager BIP30 bypass.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

55 lines

Diff 25313

View Options

[backport#12204] Fix overly eager BIP30 bypassClosedPublicActions