Page MenuHomePhabricator
Differential D8226

Remove oversized message detection from log and interface
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 21:46.

Details

Reviewers
PiRK
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC06ae90a10871: Remove oversized message detection from log and interface
Summary

Partial backport 5/7 of core PR16202:
https://github.com/bitcoin/bitcoin/pull/16202/commits/6a91499496d76c2b3e84489e9723b60514fb08db

Depends on D8225.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 1 2020, 21:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 21:46
Fabien requested review of this revision.Nov 1 2020, 21:46
teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 21:46
Fabien added a child revision: D8227: Make resetting implicit in TransportDeserializer::Read().Nov 1 2020, 21:49
Harbormaster completed remote builds in B13806: Diff 25339.Nov 1 2020, 22:06
PiRK accepted this revision.Nov 2 2020, 08:49
This revision is now accepted and ready to land.Nov 2 2020, 08:49
jasonbcox requested changes to this revision.Nov 2 2020, 22:01
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/p2p_invalid_messages.py
95 ↗(On Diff #25339)

Our implementation differs a little bit. Shouldn't this debug log assertion stay? It should still be valid. Note that the message differs from the original PR and is not the same message as the Oversized message from... that was removed above.

This revision now requires changes to proceed.Nov 2 2020, 22:01
Fabien updated this revision to Diff 25364.Nov 3 2020, 02:19

Revert the message check removal in the test, since we still have it.

Harbormaster completed remote builds in B13822: Diff 25364.Nov 3 2020, 02:31
jasonbcox accepted this revision.Nov 3 2020, 02:55
This revision is now accepted and ready to land.Nov 3 2020, 02:55
Closed by commit rABC06ae90a10871: Remove oversized message detection from log and interface (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by Fabien). · Explain WhyNov 3 2020, 10:04
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC06ae90a10871: Remove oversized message detection from log and interface.

Revision Contents
Changeset List

PathSize
src/
5 lines
8 lines

Diff 25369

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...