Use adapter pattern for the network deserializer
ClosedPublic
Actions

Authored by Fabien on Nov 1 2020, 21:39.

Details

Reviewers

PiRK
jasonbcox

Group Reviewers

Restricted Project

Commits

rABCa7040a762ffb: Use adapter pattern for the network deserializer

Summary

Partial backport 3/7 of core PR16202:
https://github.com/bitcoin/bitcoin/pull/16202/commits/efecb74677222f6c70adf7f860c315f430d39ec4

Depends on D8223.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 1 2020, 21:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2020, 21:39

Fabien requested review of this revision.Nov 1 2020, 21:39

teamcity edited the summary of this revision. (Show Details)Nov 1 2020, 21:39

Fabien added a child revision: D8225: Force CNetMessage::m_recv to use std::move.Nov 1 2020, 21:43

Harbormaster completed remote builds in B13804: Diff 25337.Nov 1 2020, 21:55

PiRK accepted this revision.Nov 2 2020, 08:45

This revision is now accepted and ready to land.Nov 2 2020, 08:45

jasonbcox accepted this revision.Nov 2 2020, 21:46

Closed by commit rABCa7040a762ffb: Use adapter pattern for the network deserializer (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyNov 3 2020, 10:02

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa7040a762ffb: Use adapter pattern for the network deserializer.

Revision Contents
Changeset List

Path

Size

src/

net.h

48 lines

net.cpp

45 lines

Diff 25367

View Options

src/net.h