Clear TestNode objects after shutdown
ClosedPublic
Actions

Authored by PiRK on Nov 3 2020, 10:23.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCdf335a36010f: Clear TestNode objects after shutdown

Summary

TestNode objects need to be removed during shutdown, as setup_nodes does not remove previous TestNode objects from previous test runs during setup.

This is a backport of Core PR17288 [4/7]
https://github.com/bitcoin/bitcoin/pull/17288/commits/614c645643e86c4255b98c663c10f2c227158d4b

Depends on D8243

Test Plan

ninja && ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13826
Build 27671: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27670: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 3 2020, 10:23

Owners added a reviewer: Restricted Owners Package.Nov 3 2020, 10:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2020, 10:23

PiRK requested review of this revision.Nov 3 2020, 10:23

teamcity edited the summary of this revision. (Show Details)Nov 3 2020, 10:24

PiRK added a child revision: D8245: Move parse_args and set_test_params to __init__.Nov 3 2020, 10:25

Fabien accepted this revision.Nov 3 2020, 10:55

This revision is now accepted and ready to land.Nov 3 2020, 10:55

Harbormaster completed remote builds in B13826: Diff 25376.Nov 3 2020, 11:05

Closed by commit rABCdf335a36010f: Clear TestNode objects after shutdown (authored by JamesC <james.chiangwu@gmail.com>, committed by PiRK). · Explain WhyNov 3 2020, 14:36

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCdf335a36010f: Clear TestNode objects after shutdown.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

2 lines

Diff 25376

View Options

test/functional/test_framework/test_framework.py

Clear TestNode objects after shutdownClosedPublicActions