Differential D8326

Refactor FormatStateMessage into ValidationState
ClosedPublic
Actions

Authored by Fabien on Nov 9 2020, 12:33.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC46a3c8ef6723: Refactor FormatStateMessage into ValidationState

Summary

Partial backport 1/3 of core PR17399:
https://github.com/bitcoin/bitcoin/pull/17399/commits/0aed17ef2892478c28cd660e53223c6dd1dc0187

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17399_part1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13935
Build 27878: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 27877: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 9 2020, 12:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 12:33

Fabien requested review of this revision.Nov 9 2020, 12:33

teamcity edited the summary of this revision. (Show Details)Nov 9 2020, 12:34

Fabien added a child revision: D8327: Remove ValidationState's constructor.Nov 9 2020, 12:34

Harbormaster completed remote builds in B13935: Diff 25567.Nov 9 2020, 12:55

majcosta accepted this revision.Nov 9 2020, 12:57

This revision is now accepted and ready to land.Nov 9 2020, 12:57

Closed by commit rABC46a3c8ef6723: Refactor FormatStateMessage into ValidationState (authored by Jeffrey Czyz <jkczyz@gmail.com>, committed by Fabien). · Explain WhyNov 9 2020, 13:48

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC46a3c8ef6723: Refactor FormatStateMessage into ValidationState.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

1 line

consensus/

11 lines

4 lines

4 lines

12 lines

node/

transaction.cpp

3 lines

rpc/

blockchain.cpp

7 lines

mining.cpp

5 lines

test/

util/

setup_common.cpp

5 lines

util/

validation.h

validation.cpp

42 lines

validationinterface.cpp

3 lines

wallet/

wallet.cpp

1 line

Diff 25567

View Options

src/CMakeLists.txt

View Options

src/consensus/validation.h

View Options

src/init.cpp

View Options

src/miner.cpp

View Options

src/net_processing.cpp

View Options

src/node/transaction.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/util/setup_common.cpp

View Options

src/util/validation.h

View Options

src/util/validation.cpp

View Options

src/validation.cpp

View Options

src/validationinterface.cpp

View Options

Refactor FormatStateMessage into ValidationStateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25567

src/CMakeLists.txt

src/consensus/validation.h

src/init.cpp

src/miner.cpp

src/net_processing.cpp

src/node/transaction.cpp

src/rpc/blockchain.cpp

src/rpc/mining.cpp

src/test/util/setup_common.cpp

src/util/validation.h

src/util/validation.cpp

src/validation.cpp

src/validationinterface.cpp

src/wallet/wallet.cpp

Refactor FormatStateMessage into ValidationState
ClosedPublic
Actions

Revision Contents
Changeset List