Page MenuHomePhabricator
Differential D8335

qt: Use SynchronizationState enum for signals to GUI
ClosedPublic
Actions

Authored by Fabien on Nov 9 2020, 15:48.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC03c8acb87d90: qt: Use SynchronizationState enum for signals to GUI
Summary
This PR is a followup of #18121 and:

    addresses confusion about GUI notification throttling conditions
    removes isInitialBlockDownload() call from the GUI back to the node
(on macOS).

Backport of core PR18152.

Depends on D8334.

Test Plan
ninja all check-all

Also run the tests on OSX.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 9 2020, 15:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2020, 15:48
Fabien requested review of this revision.Nov 9 2020, 15:48
teamcity edited the summary of this revision. (Show Details)Nov 9 2020, 15:49
Harbormaster completed remote builds in B13944: Diff 25582.Nov 9 2020, 16:00
Fabien added a comment.Nov 9 2020, 16:02

@bot build-native-osx

teamcity awarded a token.Nov 9 2020, 16:03
PiRK accepted this revision.Nov 9 2020, 16:34
This revision is now accepted and ready to land.Nov 9 2020, 16:34
Closed by commit rABC03c8acb87d90: qt: Use SynchronizationState enum for signals to GUI (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyNov 9 2020, 19:11
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC03c8acb87d90: qt: Use SynchronizationState enum for signals to GUI.
PiRK added a child revision: D8836: [refactor] interpreter: define interface for vfExec.Jan 7 2021, 17:16
majcosta mentioned this in D8836: [refactor] interpreter: define interface for vfExec.Jan 7 2021, 17:56

Revision Contents
Changeset List

PathSize
src/
18 lines
interfaces/
9 lines
11 lines
qt/
3 lines
11 lines
16 lines
5 lines
52 lines
rpc/
2 lines
2 lines
7 lines
10 lines
3 lines
21 lines

Diff 25593

View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/clientmodel.h

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/rpc/blockchain.h

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/ui_interface.h

Loading...
View Options

src/ui_interface.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...