Page MenuHomePhabricator
Differential D8836

[refactor] interpreter: define interface for vfExec
ClosedPublic
Actions

Authored by PiRK on Jan 7 2021, 17:11.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC9f3f4dd47411: [refactor] interpreter: define interface for vfExec
Summary

Includes comments added by Pieter Wuille.

This is a backport of Core PR16902 [2/3]
https://github.com/bitcoin/bitcoin/pull/16902/commits/d0e8f4d5d8ddaccb37f98b7989fb944081e41ab8

Depends on D8835

Test Plan
ninja all check-all
src/bench/bitcoin-bench -filter=VerifyNestedIfScript

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 7 2021, 17:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2021, 17:11
PiRK requested review of this revision.Jan 7 2021, 17:11
teamcity edited the summary of this revision. (Show Details)Jan 7 2021, 17:11
PiRK edited the summary of this revision. (Show Details)Jan 7 2021, 17:16
PiRK added a parent revision: D8335: qt: Use SynchronizationState enum for signals to GUI.
PiRK added a child revision: D8837: Implement O(1) OP_IF/NOTIF/ELSE/ENDIF logic.Jan 7 2021, 17:16
Harbormaster completed remote builds in B14645: Diff 26753.Jan 7 2021, 17:30
majcosta requested changes to this revision.Jan 7 2021, 17:56
majcosta added a subscriber: majcosta.

Depends on D8835 right? not D8335

This revision now requires changes to proceed.Jan 7 2021, 17:56
PiRK requested review of this revision.Jan 7 2021, 18:11
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D8835: Benchmark script verification with 100 nested IFs.

yes. Fixed.

majcosta accepted this revision.Jan 7 2021, 18:14
This revision is now accepted and ready to land.Jan 7 2021, 18:14
Closed by commit rABC9f3f4dd47411: [refactor] interpreter: define interface for vfExec (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyJan 8 2021, 07:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9f3f4dd47411: [refactor] interpreter: define interface for vfExec.

Revision Contents
Changeset List

PathSize
src/
script/
34 lines

Diff 26772

View Options

src/script/interpreter.cpp

Loading...