Refactor message transport packaging
ClosedPublic
Actions

Authored by Fabien on Nov 12 2020, 13:12.

Details

Reviewers

PiRK
jasonbcox

Group Reviewers

Restricted Project

Commits

rABC06ce66282a5d: Refactor message transport packaging

Summary

This PR factors out transport packaging logic from
CConnman::PushMessage().
It's similar to #16202 (where we refactor deserialization).

This allows implementing a new message transport protocol like BIP324.

Backport of core PR16562.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 12 2020, 13:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 12 2020, 13:12

Fabien requested review of this revision.Nov 12 2020, 13:12

teamcity edited the summary of this revision. (Show Details)Nov 12 2020, 13:12

Harbormaster completed remote builds in B13997: Diff 25679.Nov 12 2020, 13:25

PiRK accepted this revision.Nov 12 2020, 13:34

This revision is now accepted and ready to land.Nov 12 2020, 13:34

Fabien added a child revision: D8376: fuzz: Add process_messages harness.Nov 12 2020, 14:31

jasonbcox accepted this revision.Nov 12 2020, 19:42

Closed by commit rABC06ce66282a5d: Refactor message transport packaging (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyNov 13 2020, 07:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC06ce66282a5d: Refactor message transport packaging.

Revision Contents
Changeset List

Path

Size

src/

net.h

20 lines

net.cpp

29 lines

Diff 25714

View Options

src/net.h