Differential D8383

Rename BIP32PubkeyProvider.m_extkey to m_root_extkey
ClosedPublic
Actions

Authored by deadalnix on Nov 12 2020, 23:56.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCca0a03351c0d: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey

Summary

Renaming clarifies that m_extkey is actually the root
extkey that keys are derived from.

Backport of Core PR18204 part [3/7] : https://github.com/bitcoin/bitcoin/pull/18204/commits/66c2cadc91d26074b89e5ada68350b5c8676efac

Depends on D8382

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 12 2020, 23:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 12 2020, 23:56

deadalnix requested review of this revision.Nov 12 2020, 23:56

teamcity edited the summary of this revision. (Show Details)Nov 12 2020, 23:56

deadalnix added a child revision: D8384: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey.Nov 13 2020, 00:01

Harbormaster completed remote builds in B14013: Diff 25697.Nov 13 2020, 00:13

majcosta accepted this revision.Nov 13 2020, 03:16

This revision is now accepted and ready to land.Nov 13 2020, 03:16

Closed by commit rABCca0a03351c0d: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 13 2020, 13:22

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCca0a03351c0d: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey.

Revision Contents
Changeset List

Path

Size

src/

script/

descriptor.cpp

26 lines

Diff 25721

View Options

Rename BIP32PubkeyProvider.m_extkey to m_root_extkeyClosedPublicActions