Differential D8386

Cache the immediate derivation parent xpub
ClosedPublic
Actions

Authored by deadalnix on Nov 13 2020, 01:22.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCf0c918349526: Cache the immediate derivation parent xpub

Summary

If unhardened derivation is used, cache the immediate derivation
parent xpub and use it for unhardened derivation

Backport of Core PR18204 part [5/7] : https://github.com/bitcoin/bitcoin/pull/18204/commits/f76733eda5f4c161e9eb47c74b949582ab8f448a

Depends on D8384 and D8385

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 13 2020, 01:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2020, 01:22

deadalnix requested review of this revision.Nov 13 2020, 01:22

teamcity edited the summary of this revision. (Show Details)Nov 13 2020, 01:22

deadalnix added a child revision: D8387: Only cache xpubs that have a hardened last step.Nov 13 2020, 01:24

Harbormaster completed remote builds in B14016: Diff 25700.Nov 13 2020, 01:34

majcosta accepted this revision.Nov 13 2020, 04:55

This revision is now accepted and ready to land.Nov 13 2020, 04:55

Closed by commit rABCf0c918349526: Cache the immediate derivation parent xpub (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 13 2020, 13:30

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf0c918349526: Cache the immediate derivation parent xpub.

Revision Contents
Changeset List

Path

Size

src/

script/

descriptor.cpp

24 lines

test/

descriptor_tests.cpp

31 lines

Diff 25723

View Options

src/script/descriptor.cpp