Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCec5a073bd022: Cache parent xpub inside of BIP32PubkeyProvider

Summary

Optimize Expand by having BIP32PubkeyProvider also cache the parent
(or only) xpub within itself. Since Expand does not provide a read
cache, it is useful to internally cache this xpub to avoid re-deriving
the same xpub.

Backport of Core PR18204 part [7/7] : https://github.com/bitcoin/bitcoin/pull/18204/commits/09e25071f40c564af08a1386c39c4f2d8eb484b6

Depends on D8387

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 13 2020, 01:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2020, 01:27

deadalnix requested review of this revision.Nov 13 2020, 01:28

teamcity edited the summary of this revision. (Show Details)Nov 13 2020, 01:28

Harbormaster completed remote builds in B14018: Diff 25702.Nov 13 2020, 01:43

majcosta accepted this revision.Nov 13 2020, 05:02

This revision is now accepted and ready to land.Nov 13 2020, 05:02

Closed by commit rABCec5a073bd022: Cache parent xpub inside of BIP32PubkeyProvider (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyNov 13 2020, 13:34

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCec5a073bd022: Cache parent xpub inside of BIP32PubkeyProvider.

Cache parent xpub inside of BIP32PubkeyProvider
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25725

src/script/descriptor.cpp

Cache parent xpub inside of BIP32PubkeyProviderClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25725

src/script/descriptor.cpp

Cache parent xpub inside of BIP32PubkeyProvider
ClosedPublic
Actions

Revision Contents
Changeset List