Page MenuHomePhabricator
Differential D839

Allow cashaddr's prefix to be implicit
ClosedPublic
Actions

Authored by deadalnix on Dec 22 2017, 02:55.

Details

Reviewers
schancel
dagurval
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING6c9c42ccb093: Allow cashaddr's prefix to be implicit
rABC6c9c42ccb093: Allow cashaddr's prefix to be implicit
Summary

This makes for a much more pleasant UX.

Test Plan

Added unittests.

In addition, try to send coin on testnet using both cashaddr with and without prefix and legacy addresses, with and without the -usecashaddr flag.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashaddrskipprefix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1434
Build 1434: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 22 2017, 02:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2017, 02:55
Mengerian accepted this revision.Dec 22 2017, 04:24
Mengerian added a subscriber: Mengerian.

Tested sending on mainnet with and without prefix, with and without -usecashaddr

It all works as it should

This revision is now accepted and ready to land.Dec 22 2017, 04:24
schancel accepted this revision.Dec 22 2017, 06:36
Closed by commit rABC6c9c42ccb093: Allow cashaddr's prefix to be implicit (authored by deadalnix). · Explain WhyDec 22 2017, 13:50
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
40 lines
19 lines
qt/
2 lines
test/
34 lines

Diff 2221

View Options

src/cashaddr.h

Loading...
View Options

src/cashaddr.cpp

Loading...
View Options

src/cashaddrenc.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/test/cashaddr_tests.cpp

Loading...