Differential D8469

net processing: Add support for getcfilters
ClosedPublic
Actions

Authored by Fabien on Nov 19 2020, 15:52.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCeb6fae51773f: net processing: Add support for getcfilters

Summary

Support getcfilters requests when -peerblockfilters is set.

Does not advertise compact filter support in version messages.

Backport of core PR19044.

Depends on D8465.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19044

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14113
Build 28228: Build Diff	build-clang-tidy · build-clang · build-without-wallet · lint-circular-dependencies · build-debug · build-diff
Build 28227: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 19 2020, 15:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2020, 15:52

Fabien requested review of this revision.Nov 19 2020, 15:52

teamcity edited the summary of this revision. (Show Details)Nov 19 2020, 15:52

deadalnix accepted this revision.Nov 19 2020, 15:57

This revision is now accepted and ready to land.Nov 19 2020, 15:57

Harbormaster completed remote builds in B14113: Diff 25877.Nov 19 2020, 16:03

Fabien added a child revision: D8470: refactor: replace CNode pointers by references within net_processing.{h,cpp}.Nov 19 2020, 16:55

Closed by commit rABCeb6fae51773f: net processing: Add support for getcfilters (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyNov 19 2020, 17:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCeb6fae51773f: net processing: Add support for getcfilters.

Fabien mentioned this in T589: BIP157 & BIP158 backports.Dec 23 2020, 09:48

Revision Contents
Changeset List

Path

Size

src/

4 lines

96 lines

11 lines

23 lines

test/

functional/

p2p_blockfilters.py

76 lines

test_framework/

messages.py

52 lines

mininode.py

4 lines

Diff 25877

View Options

src/blockfilter.h

View Options

src/net_processing.cpp

View Options

src/protocol.h

View Options

src/protocol.cpp

View Options

test/functional/p2p_blockfilters.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/mininode.py

net processing: Add support for getcfiltersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25877

src/blockfilter.h

src/net_processing.cpp

src/protocol.h

src/protocol.cpp

test/functional/p2p_blockfilters.py

test/functional/test_framework/messages.py

test/functional/test_framework/mininode.py

net processing: Add support for getcfilters
ClosedPublic
Actions

Revision Contents
Changeset List