Adding parent dir web/ with its own "format" script to apply consistent prettier formatting to web apps in subdirectories
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- add-web-folder
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14121 Build 28244: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 28243: arc lint + arc unit
Event Timeline
| .gitignore | ||
|---|---|---|
| 83 | This doesn't appear to be used for anything. | |
| 85 | Nit: space after # | |
| web/.prettierignore | ||
| 23 | While this is ok for now, you could have added .prettierignore as it's own revision. A change like this is pretty well self-contained and can get reviewed quickly. | |
| web/package.json | ||
| 11 | I assume bitcoin-abc-web should be for bitcoinabc.org not phabricator? | |
| web/yarn.lock | ||
| 1 | Is it possible to edit yarn so that this message includes @generated? That way, it will get marked as such on phab. | |
| web/yarn.lock | ||
|---|---|---|
| 8 ↗ | (On Diff #25899) | Why do we want to use yarn in addition to node? This seems to add dependencies for things that npm already does. |
Comment Actions
Abandoning in favor of https://reviews.bitcoinabc.org/D8477, which I think offers a better approach.