Differential D8479

net: Make addr relay mockable, add test
ClosedPublic
Actions

Authored by Fabien on Nov 20 2020, 16:02.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABCada27e66ecbc: net: Make addr relay mockable, add test

Summary

As usual:

    Switch to std::chrono time to be type-safe and mockable
    Add basic test that relies on mocktime to add code coverage

Backport of core PR18454.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 20 2020, 16:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2020, 16:02

Fabien requested review of this revision.Nov 20 2020, 16:02

teamcity edited the summary of this revision. (Show Details)Nov 20 2020, 16:02

Fabien added a child revision: D8480: refactor: replace CConnman pointers by references in net_processing.cpp.Nov 20 2020, 16:06

Harbormaster completed remote builds in B14128: Diff 25907.Nov 20 2020, 16:14

deadalnix accepted this revision.Nov 21 2020, 00:38

This revision is now accepted and ready to land.Nov 21 2020, 00:38

Closed by commit rABCada27e66ecbc: net: Make addr relay mockable, add test (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 21 2020, 07:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCada27e66ecbc: net: Make addr relay mockable, add test.

Revision Contents
Changeset List

Path

Size

src/

net.h

5 lines

net_processing.cpp

29 lines

test/

functional/

p2p_addr_relay.py

71 lines

Diff 25940

View Options

src/net.h

View Options

src/net_processing.cpp

View Options

test/functional/p2p_addr_relay.py

net: Make addr relay mockable, add testClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25940

src/net.h

src/net_processing.cpp

test/functional/p2p_addr_relay.py

net: Make addr relay mockable, add test
ClosedPublic
Actions

Revision Contents
Changeset List